Human Error on Application Deletion

DouglasBaptista · March 19, 2019, 8:47pm

Good morning brocaar,

In Lora-App-Server version 2.5.1, when I have a populated Application, the button “Delete” delete all devices in an application. I think this is a too easy manner to delete all devices in one time. May cause errors in case of human mistake. One suggestion is to double-confirm the deletion of an application with more than one device activated.

Thanks,

Douglas

brocaar · March 20, 2019, 9:42am

Please note that there is already this notification:

Maybe it could be more explicit like:

Are you sure you want to delete this application? This will also delete all devices part of this application.

If you would like to create a pull-request to improve this message, that would be appreciated The source is located at:

github.com

brocaar/chirpstack-application-server/blob/master/ui/src/views/applications/ApplicationLayout.js#L81


      
            ApplicationStore.get(this.props.match.params.applicationID, resp => {
              this.setState({
                application: resp,
              });
            });
          
            SessionStore.on("change", this.setIsAdmin);
          
            this.setIsAdmin();
            this.locationToTab();
          }
          
          componentWillUnmount() {
            SessionStore.removeListener("change", this.setIsAdmin);
          }
          
          componentDidUpdate(oldProps) {
            if (this.props === oldProps) {
              return;
            }

sil · March 20, 2019, 9:57am

Hi Brocaar

As i am new to git/github i wanted to try the pull-request. i did this with your message provided.
Hopefully is all good - if not, please let me know, then i can learn from my error

regards, Sil

DouglasBaptista · March 20, 2019, 7:06pm

Brocaar, I will submit the pull-request.

Thanks!!